Skip to content

[CORRUPTED] Synthetic Benchmark PR #25691 - Switched to time-based domain warmup#236

Open
tomerqodo wants to merge 2 commits intobase_pr_25691_20260121_2148from
corrupted_pr_25691_20260121_2148
Open

[CORRUPTED] Synthetic Benchmark PR #25691 - Switched to time-based domain warmup#236
tomerqodo wants to merge 2 commits intobase_pr_25691_20260121_2148from
corrupted_pr_25691_20260121_2148

Conversation

@tomerqodo
Copy link

Benchmark PR TryGhost#25691

Type: Corrupted (contains bugs)

Original PR Title: Switched to time-based domain warmup
Original PR Description: closes GVA-617
closes GVA-619

This uses the new domain warmup algorithm that makes the warmup static:

  • The number of recipients we're targeting is 200,000
  • The number of days in which the warmup takes place is 6 weeks (42 days)

This simplifies the flow considerably, and we can experiment with the exact thresholds to make sure this is effective for most users of domain warming.


Note

Replaces threshold-based scaling with a time-based exponential warmup from 200 to 200k over 42 days, with Infinity after completion, and updates tests accordingly.

  • Email Service (DomainWarmingService.ts)
    • Replace threshold-based scaling table with time-based exponential warmup using WarmupVolumeOptions (start=200, end=200000, totalDays=42).
    • Add #getDaysSinceFirstEmail() querying first csd_email_count email (findPage with csd_email_count:-null, ordered by created_at ASC).
    • getWarmupLimit now computes limit via start * (end/start)^(day/(totalDays-1)) and returns Infinity once day >= totalDays.
  • Tests
    • Integration and unit tests updated to validate time-based limits, day progression, same-day behavior, gaps, and post-warmup Infinity.
    • Introduce deterministic time control with fake timers and adjust assertions to new query and limits.

Written by Cursor Bugbot for commit 4d1012b. This will update automatically on new commits. Configure here.

Original PR URL: TryGhost#25691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants