fix(auth): resolve session user by token subject ID#56
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| const userFromDb = await prisma.user.findUnique({ | ||
| where: { email }, | ||
| where: { email: token.email.toLowerCase() }, |
There was a problem hiding this comment.
User lookup still uses email instead of ID
High Severity
The userId is parsed from token.sub and validated, but the database query at line 64-65 still looks up users by email instead of by id. The PR intends to resolve users by token subject ID, and the tests expect where: { id: userId }, but the implementation uses where: { email: token.email.toLowerCase() }. The computed userId variable is never used for its intended purpose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#290
Note
Improves server-side session resolution and adds coverage.
token.subtouserId, warn and returnnullif invalid; minor refactor to inline lowercased email infindUniquequery__mocks__/getServerSession.mocks.tsproviding Prisma, logger, repositories, utilities, and token/user factoriesgetServerSession.test.tswith cases for token validation, user ID validation, user lookup/resolution viasub, session shape, and ensuring queries useidWritten by Cursor Bugbot for commit 04dcede. Configure here.