refactor: Remove trpc/react dependency from @calcom/atoms#60
Conversation
Comment on lines
+304
to
310
| {teamMembers.map((member) => ( | ||
| <TeamMemberItem key={member.value} member={member} onWeightChange={handleWeightChange} /> | ||
| ))} | ||
| {filteredMembers.length === 0 && ( | ||
| {teamMembers.length === 0 && ( | ||
| <div className="text-subtle py-4 text-center text-sm">{t("no_members_found")}</div> | ||
| )} | ||
| </div> |
There was a problem hiding this comment.
Bug: The component renders the full teamMembers list instead of the filteredMembers list, making the search input and member filtering non-functional.
Severity: MEDIUM
Suggested Fix
In EditWeightsForAllTeamMembers.tsx, change the list rendering logic to iterate over filteredMembers instead of teamMembers. This will ensure the rendered list correctly reflects the search query and other applied filters.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location:
apps/web/modules/event-types/components/EditWeightsForAllTeamMembers.tsx#L304-L310
Potential issue: In the `EditWeightsForAllTeamMembers` component, the list of team
members is rendered by iterating over the `teamMembers` prop directly. However, the
component also computes a `filteredMembers` variable to handle user input from a search
field and to filter members based on the `assignAllTeamMembers` flag. Because the
rendered list uses the unfiltered `teamMembers` array, both the search functionality and
the conditional member filtering are broken. The `filteredMembers` variable is
calculated but never used.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#722