fix(web): enable JSON_OBJECT type support in console UI#15
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const handleConfirm = () => { | ||
| const jsonSchemaValue = tempPayload.json_schema | ||
| const isSchemaEmpty = isJsonSchemaEmpty(jsonSchemaValue) | ||
| const normalizedJsonSchema = isSchemaEmpty ? undefined : jsonSchemaValue |
There was a problem hiding this comment.
Unused variable normalizedJsonSchema is dead code
Low Severity
The variable normalizedJsonSchema is computed but never used in the handleConfirm function. The actual saving logic uses payloadToSave instead, which computes the same logic inline. This leaves normalizedJsonSchema as dead code that adds confusion without providing value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR from qodo-benchmark#439
Note
Adds usable JSON object variables to advanced apps and improves schema handling.
jsonObjecttype in type selector (non-basic apps) and removes unusedjsonObjectWrapusageproperties), preserves formatting, and clearsjson_schemawhen emptytype: "object"); normalizes saved payload accordinglyjsonConfigPlaceHolderto a full object schema exampleWritten by Cursor Bugbot for commit a54737d. Configure here.