Skip to content

fix(web): enable JSON_OBJECT type support in console UI#15

Open
tomerqodo wants to merge 5 commits intocursor_combined_20260121_qodo_grep_cursor_copilot_1_base_fixweb_enable_json_object_type_support_in_console_ui_pr439from
cursor_combined_20260121_qodo_grep_cursor_copilot_1_head_fixweb_enable_json_object_type_support_in_console_ui_pr439
Open

fix(web): enable JSON_OBJECT type support in console UI#15
tomerqodo wants to merge 5 commits intocursor_combined_20260121_qodo_grep_cursor_copilot_1_base_fixweb_enable_json_object_type_support_in_console_ui_pr439from
cursor_combined_20260121_qodo_grep_cursor_copilot_1_head_fixweb_enable_json_object_type_support_in_console_ui_pr439

Conversation

@tomerqodo
Copy link

@tomerqodo tomerqodo commented Jan 21, 2026

Benchmark PR from qodo-benchmark#439


Note

Adds usable JSON object variables to advanced apps and improves schema handling.

  • Exposes jsonObject type in type selector (non-basic apps) and removes unused jsonObjectWrap usage
  • JSON Schema editor now accepts full schema (not just properties), preserves formatting, and clears json_schema when empty
  • Validates schema on confirm (must be valid JSON with type: "object"); normalizes saved payload accordingly
  • Updates jsonConfigPlaceHolder to a full object schema example
  • Adds localized error messages for schema validation across all supported locales

Written by Cursor Bugbot for commit a54737d. Configure here.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

const handleConfirm = () => {
const jsonSchemaValue = tempPayload.json_schema
const isSchemaEmpty = isJsonSchemaEmpty(jsonSchemaValue)
const normalizedJsonSchema = isSchemaEmpty ? undefined : jsonSchemaValue
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused variable normalizedJsonSchema is dead code

Low Severity

The variable normalizedJsonSchema is computed but never used in the handleConfirm function. The actual saving logic uses payloadToSave instead, which computes the same logic inline. This leaves normalizedJsonSchema as dead code that adds confusion without providing value.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants