[CORRUPTED] Synthetic Benchmark PR #30962 - Refactor FXIOS-12796 [Swift 6 Migration] Fix strict concurrency warnings in the CredentialsProvider#248
Closed
tomerqodo wants to merge 3 commits intobase_pr_30962_20260121_8042from
Conversation
|
This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark PR mozilla-mobile#30962
Type: Corrupted (contains bugs)
Original PR Title: Refactor FXIOS-12796 [Swift 6 Migration] Fix strict concurrency warnings in the
CredentialsProviderOriginal PR Description: ## 📜 Tickets
Jira ticket
Github issue
Also addresses FXIOS-13149.
💡 Description
Fix warnings in the
CredentialsProvider.See the unit testing slack channel for a Nov 26. demo on how to test the Credentials Provider feature (i.e. how to use Firefox as a password manager for Safari and for itself).
cc @Cramsden @lmarceau @dataports
📝 Checklist
Original PR URL: Refactor FXIOS-12796 [Swift 6 Migration] Fix strict concurrency warnings in the
CredentialsProvidermozilla-mobile/firefox-ios#30962