Skip to content

gst-sample-apps: Update package config and enable sample apps packaging#1530

Open
muthumul wants to merge 2 commits intoqualcomm-linux:masterfrom
muthumul:test-meta-qcom-new
Open

gst-sample-apps: Update package config and enable sample apps packaging#1530
muthumul wants to merge 2 commits intoqualcomm-linux:masterfrom
muthumul:test-meta-qcom-new

Conversation

@muthumul
Copy link

@muthumul muthumul commented Feb 11, 2026

This updates the IMSDK GStreamer plugin packaging and configuration to properly include the sample applications and ensure correct installation.

quaresmajose
quaresmajose reviewed Feb 11, 2026
View reviewed changes
@ricardosalveti
Copy link
Contributor

ricardosalveti commented Feb 11, 2026

Missing SoB / DCO.

@muthumul muthumul closed this Feb 19, 2026
@muthumul
Copy link
Author

muthumul commented Feb 19, 2026

Added a couple of more changes, will raise this on the latest changes.

@lumag lumag reopened this Feb 20, 2026
@lumag
Copy link
Contributor

lumag commented Feb 20, 2026

Please don't close the PRs just to add more changes

@ricardosalveti
Copy link
Contributor

ricardosalveti commented Feb 23, 2026

Please rebase as there is now a conflict.

lumag
lumag requested changes Feb 23, 2026
View reviewed changes
Copy link
Contributor

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

@muthumul muthumul force-pushed the test-meta-qcom-new branch 2 times, most recently from f7c313f to 8667de7 Compare February 24, 2026 08:19
@muthumul
Copy link
Author

muthumul commented Feb 24, 2026 •
edited
Loading

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

@muthumul muthumul closed this Feb 24, 2026
@muthumul muthumul reopened this Feb 24, 2026
@muthumul
Copy link
Author

muthumul commented Feb 24, 2026

Sorry closed it by mistake.

@muthumul
Copy link
Author

muthumul commented Feb 24, 2026

Please rebase as there is now a conflict.

I have rebased the changes on the latest pull.

anujm1
anujm1 reviewed Feb 24, 2026
View reviewed changes
recipes-multimedia/imsdk/gst-plugins-imsdk-packaging.inc Outdated
do_split_packages(d, imsdk_root, r'([^/]+)/modules/[^/]+\.so', d.expand('${PN}-%s-modules'), 'IMSDK runtime modules for %s plugin', recursive=True, extra_depends='', match_path=True)

# Qualcomm Gstreamer sample apps binaries
do_split_packages(d, bindir, r'^(.*)$', d.expand('${PN}-bin-%s'), 'Qualcomm Gstreamer Sample Apps Executable %s for $|{PN}', extra_depends='')
Copy link
Contributor

@anujm1 anujm1 Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will this description expand to? Qualcomm Gstreamer Sample Apps Executable gst-weston-composition-example for $PN? This doesn't sound right.

Copy link
Author

@muthumul muthumul Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed this split logic entirely. Thank you.

@anujm1
Copy link
Contributor

anujm1 commented Feb 24, 2026

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

anujm1
anujm1 reviewed Feb 24, 2026
View reviewed changes
@lumag
Copy link
Contributor

lumag commented Feb 24, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

@muthumul
Copy link
Author

muthumul commented Feb 24, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you.

@ricardosalveti
Copy link
Contributor

ricardosalveti commented Feb 24, 2026

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

You have 'sample-apps:', please use 'gst-plugins-imsdk:' instead.

@lumag
Copy link
Contributor

lumag commented Feb 24, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you.

Author field is still wrong . There is a argument to set it to the correct value.

@muthumul muthumul force-pushed the test-meta-qcom-new branch 2 times, most recently from 196dd61 to 71d3409 Compare February 25, 2026 09:46
@muthumul
Copy link
Author

muthumul commented Feb 25, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you.

Author field is still wrong . There is a argument to set it to the correct value.

Is it --author? I have added it.

@muthumul
Copy link
Author

muthumul commented Feb 25, 2026

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

You have 'sample-apps:', please use 'gst-plugins-imsdk:' instead.

I have made the change. Thank you.

@muthumul
Copy link
Author

muthumul commented Feb 25, 2026

sample-apps: add per-binary split packaging for sample-apps

The commit message should start with recipe-name:

Thanks for pointing it out. I have updated the commit message accordingly.

@muthumul muthumul requested a review from lumag February 25, 2026 09:55
@muthumul muthumul requested a review from koenkooi as a code owner February 25, 2026 20:50
@muthumul muthumul force-pushed the test-meta-qcom-new branch 2 times, most recently from 5e51510 to ebb4219 Compare February 27, 2026 05:41
@muthumul
Copy link
Author

muthumul commented Feb 27, 2026

Signed-off-by: muthumul muthumul@qti.qualcomm.com

muthumul is not your name.

I have updated it. Thank you for pointing it out.

Not completely:

From: muthumul muthumul@qti.qualcomm.com

I have updated in the signed-off-by, right? Can you please tell me where else I need to make this change? Thank you.

Author field is still wrong . There is a argument to set it to the correct value.

Is it --author? I have added it.

Hey @lumag ,

image

Please let me know if I have made change correctly. Because I can see that my actual name is appearing as the author. Thank you.

@lumag
Copy link
Contributor

lumag commented Feb 27, 2026

@muthumul you will be told if something is incorrect. If there are no additional comments, then it's fine.

@ricardosalveti
Copy link
Contributor

ricardosalveti commented Feb 28, 2026

Fails to build:

2026-02-27 23:03:12 - INFO     - | -- Checking for module 'gstreamer-webrtc-1.0>=1.16'
2026-02-27 23:03:12 - INFO     - | --   No package 'gstreamer-webrtc-1.0' found
2026-02-27 23:03:12 - INFO     - | CMake Error at /work/build/tmp/work/armv8-2a-qcom-linux/gst-plugins-imsdk/0.0+git/recipe-sysroot-native/usr/share/cmake-4.2/Modules/FindPkgConfig.cmake:1093 (message):
2026-02-27 23:03:12 - INFO     - |   The following required packages were not found:
2026-02-27 23:03:12 - INFO     - |
2026-02-27 23:03:12 - INFO     - |    - gstreamer-webrtc-1.0>=1.16
2026-02-27 23:03:12 - INFO     - |
2026-02-27 23:03:12 - INFO     - | Call Stack (most recent call first):

@muthumul
gst-plugins-imsdk: add configs package and introduce sample-apps PACK…
1a9278f 
…AGECONFIG

Added ${PN}-configs package to install sample app configuration files under ${sysconfdir}/configs/.
Introduced 'sample-apps' PACKAGECONFIG option in gst-plugins-imsdk to allow enabling sample applications
when required.

Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
@muthumul
gst-plugins-imsdk: enable sample-apps by default.
370c7b3 
Enabled the sample-apps option in PACKAGECONFIG, but only when meta-oe is part of the layer stack.
This allows the sample applications to be built.

Signed-off-by: Muthumula Sai Harshith Reddy <muthumul@qti.qualcomm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quaresmajose quaresmajose quaresmajose left review comments

@anujm1 anujm1 anujm1 left review comments

@vkraleti vkraleti Awaiting requested review from vkraleti vkraleti is a code owner

@ricardosalveti ricardosalveti Awaiting requested review from ricardosalveti ricardosalveti is a code owner

@sbanerjee-quic sbanerjee-quic Awaiting requested review from sbanerjee-quic sbanerjee-quic is a code owner

@ndechesne ndechesne Awaiting requested review from ndechesne ndechesne is a code owner

@lumag lumag Awaiting requested review from lumag lumag is a code owner

@koenkooi koenkooi Awaiting requested review from koenkooi koenkooi is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@muthumul @ricardosalveti @lumag @anujm1 @quaresmajose