gst-plugins-imsdk: Enable qmmfsrc plugin#1558
gst-plugins-imsdk: Enable qmmfsrc plugin#1558skomakul wants to merge 2 commits intoqualcomm-linux:masterfrom
Conversation
|
This does too much in a single commit, at a minimum the bbappend addition needs to be its own commit. |
koenkooi
left a comment
koenkooi
left a comment
There was a problem hiding this comment.
This does too much in a single commit, at a minimum the bbappend addition needs to be its own commit.
skomakul
force-pushed
the
qmmfsrc_enable
branch
2 times, most recently
from
e8772bc to
33ccd39
Compare
Agreed, created separate commit for bbappend |
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Write commit messages as text rather than bullet lists
This change enables the qmmfsrc plugin and updates the recipe to properly handle its dependencies and packaging: Added qmmfsrc to PACKAGECONFIG. Excluded qmmfsrc from the opensource package group. Signed-off-by: Shyam Komakula <skomakul@qti.qualcomm.com>
Added qmmfsrc to dynamic-layers since it depends on 'client', which in turn depends on protobuf provided by the meta-openembedded layer. Signed-off-by: Shyam Komakula <skomakul@qti.qualcomm.com>
skomakul
force-pushed
the
qmmfsrc_enable
branch
from
ac25a57 to
1101ee5
Compare
lumag
left a comment
lumag
left a comment
There was a problem hiding this comment.
Added qmmfsrc to PACKAGECONFIG.
Excluded qmmfsrc from the opensource package group.
Don't describe what was done. Describe why it is done.
|
In your first commit you are not really enabling the plugin, you are adding the support to allow qmmfsrc to be built, so say that instead. Also, please explain what qmmfsrc actually does, in a short summary, to justify having it here. In your second commit you are not really enabling in meta-openembedded, you can just say that you are enabling such PACKAGECONFIG by default, saying why and that it is done under dynamic-layers due the protobuf dependency. |
ricardosalveti
requested review from
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
|
It's not ready until we merge camera service |
4 participants
Added qmmfsrc to PACKAGECONFIG
This allows the plugin to be enabled when building gst-plugins-imsdk.
Excluded qmmfsrc from the opensource package group
The plugin relies on components that are not part of the public opensource deliverables.
Added qmmfsrc under dynamic-layers
The plugin depends on the client component, which internally depends on protobuf coming from the meta-openembedded layer.
Adding it to dynamic layers ensures correct layer ordering and dependency availability.