linux-qcom: specify dummy revision for devupstream#1560
Open
anujm1 wants to merge 1 commit intoqualcomm-linux:masterfrom
Open
linux-qcom: specify dummy revision for devupstream#1560anujm1 wants to merge 1 commit intoqualcomm-linux:masterfrom
anujm1 wants to merge 1 commit intoqualcomm-linux:masterfrom
Conversation
While correct, specifying AUTOREV in a recipe makes bitbake query the repository while parsing. That in turn leads to build failures in case of offline builds. Specify the same revision as current fixed revision for devupstream as well to avoid this. It should be overridden by the user in local.conf. Signed-off-by: Anuj Mittal <anuj.mittal@oss.qualcomm.com>
anujm1
requested review from
lumag,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
lumag
requested changes
Feb 13, 2026
| SRCREV:class-devupstream ?= "${AUTOREV}" | ||
|
|
||
| # Pin this to the qcom-next-6.19-rc6-20260207, override this in local.conf | ||
| SRCREV:class-devupstream ?= "ccc1345fb4742e377d7d89658efe085c62c25164" |
Contributor
There was a problem hiding this comment.
This should be using something like linux-yocto-dev:
SRCREV ?= '${@oe.utils.conditional("PREFERRED_PROVIDER_virtual/kernel", "linux-qcom-next-upstream", "${AUTOREV}", "29594404d7fe73cd80eaa4ee8c43dcc53970c60e", d)}'
(yes, 3.7 was a good kernel)
Contributor
Author
There was a problem hiding this comment.
For an offline build with linux-qcom-next-upstream, it would still require a user to add an entry in local.conf to override SRCREV. So, does this approach offer any advantage?
linux-yocto-dev does not inherit devupstream while all others inheriting it expect users to override SRCREV in local.conf so it offers a consistent behaviour.
Contributor
There was a problem hiding this comment.
I find it wasier to switch PREFERRED_PROVIDER in local.conf than switching provider and setting the AUTOREV.
Test run workflowTest jobs for commit c6a671e
All jobs summary
|
Test Results 31 files 31 suites 1h 46m 50s ⏱️ For more details on these failures, see this check. Results for commit c6a671e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While correct, specifying AUTOREV in a recipe makes bitbake query the repository while parsing. That in turn leads to build failures in case of offline builds.
Specify the same revision as current fixed revision for devupstream as well to avoid this. It should be overridden by the user in local.conf.