Making OF compatible with cirq>0.15#793
Merged
ncrubin merged 2 commits intoquantumlib:masterfrom Jul 25, 2022
Merged
Conversation
With the removal of final_state_vector from the Circuit object we move the final_state_vector to the simulator.simulate result. update requirements and CI pin to cirq 1.0 unpin from 1.0 update ci workflow bump min version in CI since 3.6 is no longer supported
Collaborator
|
for anyone reading along: you could also do |
mpharrigan
reviewed
Jul 25, 2022
.github/workflows/ci.yml
Outdated
| - os: ubuntu-latest | ||
| python-version: 3.8 | ||
| cirq-version: '~=0.12.0' | ||
| cirq-version: '~=1.0.0' |
Collaborator
There was a problem hiding this comment.
the comment in this include block says this is supposed to test the least-supported versions (linux only). Here, you've changed it to check newest version of cirq but with oldest version of python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the removal of final_state_vector from the Circuit object
we move the final_state_vector to the simulator.simulate result.
update requirements and CI
pin to cirq 1.0
unpin from 1.0
update ci workflow
bump min version in CI since 3.6 is no longer supported