Fix scipy sqrtm precision issue#864
Merged
fdmalone merged 5 commits intoquantumlib:masterfrom Jan 16, 2024
Merged
Conversation
Collaborator
Author
|
See #865 which tracks the capping of cirq for the CI. |
Collaborator
Author
|
Will need to cut a new release to fix #851. |
Collaborator
Author
|
I need to fix a comment typo don't merge. |
This was referenced Jan 16, 2024
|
Hey happy to see this fixed! Any idea when it will be released? It will help us unblock some dependency upgrades over on unitaryfund/mitiq. |
Collaborator
Author
|
@natestemen I'll aim to release a patch by the end of the week. |
|
hi @fdmalone, hope you don't mind my asking when the patch mentioned in the previous comment is likely to be released? As my teammate Nate mentioned last week, folks on the Mitiq project are excited to see this upgrade in the pipeline! |
Collaborator
Author
|
@Misty-W , I just released a patched verison |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #815 by replacing la.sqrtm with the square root computed via eigendecomposition. Just bumping the input array's precision to 256 didn't solve the problem.