Handle nested transactions in Rails 5

[greysteil]

Currently, the setup added to the spec in the PR causes a NoMethodError: 'undefined method add_to_transaction' when running against ActiveRecord 5.

This PR adds a naive fix, which makes Que compatible with ActiveRecord 5. It's not the best possible solution (which is described in a comment), but it removes the blocker for anyone moving to Rails 5.

[greysteil]

@chanks - would be awesome if you could take a quick look over this now Rails 5 is out. Am I right that calling wake! here would be a nice to have, and needn't be a blocker for people updating?

[chanks]

I'll be able to look at it tomorrow, Friday is my open source day at work.

On Thursday, June 30, 2016, Grey Baker notifications@github.com wrote:

@chanks https://github.com/chanks - would be awesome if you could take
a quick look over this now Rails 5 is out. Am I right that calling wake!
here would be a nice to have, and needn't be a blocker for people updating?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#160 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AASUGkWjfifo9zzu6k7HMGIwTYH-Wx82ks5qRF58gaJpZM4JATpX
.

[chanks]

Looked at it, yeah, you're right, calling wake! would be a nice-to-have, but I don't think it's strictly necessary. And I'd worry about maintaining backward compatibility with older versions of Rails with more invasive changes.

Will merge and release a new minor version. Thanks!