Add backtrace to errors#328
Merged
maddymarkovitz merged 3 commits intoque-rb:masterfrom Feb 21, 2022
Merged
Conversation
To better debug failing jobs, this adds extra information to the error logs.
error.cause isn't producing any valuable output, so removing it from the logs.
ZimbiX
approved these changes
Jan 25, 2022
Member
ZimbiX
left a comment
ZimbiX
left a comment
There was a problem hiding this comment.
Good idea; I've had to open up the jobs table many times to look at the backtrace. Thanks!
maddymarkovitz
approved these changes
Jan 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were having issues where jobs were failing, but the error
ArgumentErrorwasn't providing much information about where the problem was occurring.This change adds a backtrace to the error logs, and also changes the other instance logging of the backtrace to be a bit more paranoid, in that the
backtracemethod may return anilor an array.I'd suggest a squash merge of these commits, if that's OK.