fix que:work task to actually wait for running jobs to finish#85
Merged
chanks merged 1 commit intoque-rb:masterfrom Feb 6, 2015
Merged
fix que:work task to actually wait for running jobs to finish#85chanks merged 1 commit intoque-rb:masterfrom
chanks merged 1 commit intoque-rb:masterfrom
Conversation
chanks
added a commit
that referenced
this pull request
Feb 6, 2015
fix que:work task to actually wait for running jobs to finish
Collaborator
|
Thanks! Definitely an oversight on my part. I'll release a new version momentarily. And yeah, the API needs rethinking before 1.0. The mode setting hasn't been as useful as I'd hoped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that after commit 3981bd4,
que:workrake task actually stopped waiting for jobs to finish despite claiming to do so. I made a little fix settingQue.worker_countto 0, however I don't understand why setting mode to :off doesn't do that.