feat: Creating a hyperSpec object without spectra#146
Open
Suryansh-Dey wants to merge 1 commit intor-hyperspec:developfrom
Open
feat: Creating a hyperSpec object without spectra#146Suryansh-Dey wants to merge 1 commit intor-hyperspec:developfrom
Suryansh-Dey wants to merge 1 commit intor-hyperspec:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99
Line causing the problem In
.initialize(), when bothspcanddata$spcare NULL, the constructor creates a 0×0 empty matrix:This ignores nrow(data), causing a row-count mismatch that fails validation.
Fix: Just Accounted for nrow(data) when constructing the empty spectra matrix.
The PR is too simple to be true, am I missing something? Please correct me.
I did run all tests:
_R_CHECK_FORCE_SUGGESTS_=false R CMD check --no-manual --no-vignettes hyperSpec_*.tar.gz
2 fails are due to missing suggested packages which has nothing to do with our
initialize.Rchanges