Added support for Geometry and Geography data types#311
Open
svats0001 wants to merge 9 commits into
Open
Conversation
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Member
|
Thanks a lot. What is the reason integration tests do not work for you? |
Author
|
I thought there was going to be a CI/CD pipeline as part of checks like in another project but it's fine. I've set up Docker and the integration tests are running now, I'm getting an error which I'll try and fix up in the near future and push the changes and let you know, |
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Signed-off-by: S V <vats02581@gmail.com>
Author
|
@mp911de The unit tests and integration tests are passing now and I've submitted the code changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mp911de
#### Issue description
#65 Added support for Geometry and Geography data types with the creation of codecs and tests.
#### New Public APIs
Removed test scope from com.microsoft.sqlserver.mssql-jdbc in order to use Geography and Geometry classes.
#### Additional context
None.
EDIT: Have run unit tests locally which succeeded. Not able to run codec integration test locally though.