Log errors when policy change notifications fail (backport #15525)#15526
Merged
michaelklishin merged 1 commit intov4.2.xfrom Feb 21, 2026
Merged
Log errors when policy change notifications fail (backport #15525)#15526michaelklishin merged 1 commit intov4.2.xfrom
michaelklishin merged 1 commit intov4.2.xfrom
Conversation
Previously, exceptions during policy change notifications in rabbit_policy:update_matched_objects/3 were silently swallowed by bare `catch` expressions. This meant that if a decorator's policy_changed callback failed (e.g. due to a node being unreachable), the error was invisible in the logs. The policy itself was persisted, but the side effects (such as starting or stopping federation links) never took place, requiring a node restart to take effect. (cherry picked from commit 3576ee8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, exceptions during policy change notifications in
rabbit_policy:update_matched_objects/3were silently swallowed by barecatchexpressions. This meant that if a decorator'spolicy_changedcallback failed (e.g. due to a node being unreachable), the error was invisible in the logs.The policy itself was persisted, but the side effects (such as starting or stopping federation links) never took place, requiring a node restart to take effect.
This is an automatic backport of pull request #15525 done by [Mergify](https://mergify.com).