This repository was archived by the owner on Apr 16, 2025. It is now read-only.
Conversation
Contributor
Author
|
Uhm yeah, the e2e test fails on CI. It works locally though, check it out. |
Contributor
Author
|
Superseded by #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a very simple git HTTP/3 server and client transport using custom TLS certificate validation rules (basically, a self-signed cert using the device key is presented). See inline commentary for pointers where we're not there yet.
One major peculiarity is registering the transport with
libgit, which needs to happen only once. We will need to rework the library such that it forces the user to run some initialisation logic.I also thought it might be overall the most straightforward to just use HTTP/3 instead of a custom protocol over plain QUIC, but I'm not sure how smart this is. Basically, my thoughts were: ALPN (application-level protocol negotiation) happens on the connection level, not streams. So, if we negotiate a custom protocol, it will be a bit tricky to "upgrade" an individual stream to HTTP/3 if so desired. Otoh, we could just use HTTP/3 and use normal request matching to dispatch different protocol concerns. This feels a bit clunky, however. Specifically, support for streaming request bodies seems a bit tricky due to having to switch between synchronous (
libgittransport) and asynchronous code (quinn).Let me know what you think.