Skip to content

Commits in the PRs created by upmerge workflow should be signed #2201

Open

Description

@ytimocin

Bug information

Steps to reproduce (required)

Run upmerge workflow and see that the DCO in the PR created is false.

Observed behavior (required)

DCO fails

Image

Desired behavior (required)

DCO should pass by default.

Workaround (optional)

You can set the DCO to pass manually.

System information

rad Version (required)

edge

Operating system (required)

Additional context

AB#14753

Activity

  1. added
    bugSomething is broken or not working as expected
    on Mar 4, 2025
  2. added
    triagedThis item has been triaged by project maintainers and is in the backlog
    on Mar 10, 2025
  3. brooke-hamilton commented on Mar 10, 2025

    @brooke-hamilton
    Member

    This is related to the release.yaml workflow. That workflow calls release-samples.sh, which is missing the --signoff from the commit command.

    Here's the commit command in the upmerge workflow: git commit --signoff --message "Upmerge to edge".

    Here's the commit command in the release.yaml workflow.

    For an example of this, see PR #2200. There are two commits by the rad-ci-bot: the first one, which is the upmerge, has the signoff, and the second one doesn't, which is the release workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or not working as expectedtriagedThis item has been triaged by project maintainers and is in the backlog

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions