Skip to content

Update @azure/msal-node to 7.1.2 in samples/demo - #2726

Open
nithyatsu wants to merge 1 commit into
v0.62from
nithyatsu-rca-dependabot-failures
Open

nithyatsu wants to merge 1 commit into
v0.62from
nithyatsu-rca-dependabot-failures

Conversation

@nithyatsu

Copy link
Copy Markdown
Contributor

Summary

Refresh samples/demo/package-lock.json so @azure/identity resolves to 4.14.1, which pulls in @azure/msal-node 7.1.2. This fixes Dependabot alert #426 (GHSA-xcx6-jx8p-x3h5).

Reason for change

Dependabot couldn't fix this alert on its own. @azure/monitor-opentelemetry depends on @azure/identity, and every identity release before 4.14.1 capped msal-node below 7. The fix is 7.1.0. identity 4.14.1 came out on Oct 29 and allows ^7.1.0, and monitor-opentelemetry already accepts it, so a lockfile refresh is enough. No package.json change and no override.

The other rows in #2722 came from the old v0.61 default branch. The body-parser auth failure was the private registry URLs that #2719 removed, and those alerts are already fixed.

Part of #2722

How to test

  1. From samples/demo, run npm update @azure/identity --package-lock-only. Expected: only @azure/identity (4.14.0 to 4.14.1), @azure/msal-node (6.0.1 to 7.1.2), and the nested @azure/msal-common (16.14.1 to 16.15.0) change.
  2. Run grep -c '"resolved"' samples/demo/package-lock.json. Expected: 0.
  3. The Build samples workflow on this PR builds the samples/demo image with npm ci on node 22. msal-node 7 needs node 20 or later.

File change summary

File Summary of change
samples/demo/package-lock.json Bump @azure/identity to 4.14.1, @azure/msal-node to 7.1.2, and the nested @azure/msal-common to 16.15.0.

Refresh the lockfile so @azure/identity resolves to 4.14.1, which
allows @azure/msal-node ^7.1.0. Fixes GHSA-xcx6-jx8p-x3h5.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Nithya Subramanian <nithyasu@microsoft.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@azure/identity 4.14.1 🟢 7.1
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 7Found 10/13 approved changesets -- score normalized to 7
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Security-Policy🟢 10security policy file detected
License🟢 10license file detected
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 5branch protection is not maximal on development and all release branches
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 9binaries present in source code
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Fuzzing⚠️ 0project is not fuzzed
npm/@azure/msal-common 16.15.0 🟢 6
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/@azure/msal-node 7.1.2 🟢 6
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Maintained🟢 1030 commit(s) and 2 issue activity found in the last 90 days -- score normalized to 10
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection⚠️ 1branch protection is not maximal on development and all release branches
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • samples/demo/package-lock.json

@nicolejms nicolejms left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one non-blocking comment on the unrelated integrity hash changes.

"node_modules/jsonwebtoken": {
"version": "9.0.3",
"integrity": "sha512-MT/xP0CrubFRNLNKvxJ2BYfy53Zkm++5bX9dtuPbqAeQpTVe0MQTFhao8+Cp//EmJp244xt6Drw/GVEGCUj40g==",
"integrity": "sha1-bNV6sB6bCsB8uEfVPTybbuMfeuI=",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: Please restore the original SHA-512 integrity values for the 13 packages whose versions did not change. This update also replaces those hashes with SHA-1, which reduces collision resistance and is not needed for the MSAL fix. Keep the three intended package version updates.

@nithyatsu
nithyatsu enabled auto-merge (squash) November 4, 2026 18:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants