Skip to content

Add imx214 support for q6a#523

Closed
RadxaSongjun wants to merge 2 commits into
radxa:linux-6.18.2from
RadxaSongjun:linux-6.18.2
Closed

Add imx214 support for q6a#523
RadxaSongjun wants to merge 2 commits into
radxa:linux-6.18.2from
RadxaSongjun:linux-6.18.2

Conversation

@RadxaSongjun

Copy link
Copy Markdown

No description provided.

Signed-off-by: SongJun Li <lisongjun@radxa.com>

@RadxaYuntian RadxaYuntian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable_gpio应该就是reset脚才对呀。你现在定义的enable_gpio难道是供电?供电要用单独的regulator结点来使能

@RadxaSongjun

Copy link
Copy Markdown
Author

enable_gpio应该就是reset脚才对呀。你现在定义的enable_gpio难道是供电?供电要用单独的regulator结点来使能

对比6.1内核代码 这个应该是 pwdn 脚,6.18内核的 imx214 去掉了 reset 脚的控制,可能是将这个复位动作交给硬件了

@RadxaYuntian

Copy link
Copy Markdown
Member

@RadxaYuntian

Copy link
Copy Markdown
Member

另外就别搬下游的非标实现了

@RadxaYuntian RadxaYuntian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉应该有一些不需要更改驱动的方式来驱动这个信号(比如gpio hogging),但目前就先这样吧

Signed-off-by: SongJun Li <lisongjun@radxa.com>
@RadxaStephen

Copy link
Copy Markdown
Member

Related radxa-pkg/radxa-overlays#502

@RadxaYuntian RadxaYuntian left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RadxaStephen

Copy link
Copy Markdown
Member

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants