Intentions for integrating with Propshaft?

[rmacklin]

I know development on this stuff is still very much in progress, but is it correct to assume that we'll want this gem to work with Propshaft (i.e. in apps that use an alternative asset pipeline to Sprockets)? From what I've seen so far, it doesn't seem like the gem needs any of the more complex Sprockets-specific stuff.

But I noticed the gem currently has a direct reference to a Sprockets constant here:

importmap-rails/lib/importmap/map.rb

Line 94 in a2e5632

rescue Sprockets::Rails::Helper::AssetNotFound

Would we want to generalize it such that we only reference that constant when Sprockets has been loaded (after checking if defined?(Sprockets::Rails) or something similar)?

[dhh]

Yes, let's definitely guard against this. Propshaft should indeed be made compatible here.

[rmacklin]

Sounds good, I'll work on a PR. And likely one as well in https://github.com/rails/propshaft because I was looking further into this and noticed that, unlike sprockets-rails, in Propshaft's compute_asset_path helper we don't seem to raise if an asset isn't found:
https://github.com/rails/propshaft/blob/e07841a8f1b4e16d60393082996e1177152aca81/lib/propshaft/helper.rb#L2-L4

If the resolvers return nil (here or here), then so will compute_asset_path. That will make typos result in a tag like <script src=""></script>:

So I'm going to make PR into Propshaft to make such errors more noticeable (here's the PR where sprockets-rails did so: rails/sprockets-rails#375)