Resolve breaking change in Rollup v3#133
Merged
dhh merged 2 commits intorails:mainfrom Dec 14, 2022
mattgauf:main
Merged
Conversation
Contributor
Author
|
@dhh Sorry to bother you, I just wanted to follow up on this and make sure someone was aware of this issue and pull request. If there is anything else I need to do please let me know! |
Contributor
Author
|
@rafaelfranca Just following up on this; is there anything I need to do before this can be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup has just pushed a major release. (Currently 3.0.1)
This update implements a change for rollup.config.js which requires that it conform to a module to continue use of 'import'. New apps to run
javascript:install:rolluppull this latest version but use a (now) broken rollup.config.js.This triggers unhelpful errors during install.
A flag can be used to bypass the new module requirement.
See: https://rollupjs.org/guide/en/#--bundleconfigascjs
This PR implements the latter solution as a temporary fix until someone can formally review how the new convention used in rollup.config.js affects rails apps.