Skip to content

Use float library comparison function instead of wrapper #2449

@findolor

Description

@findolor

Summary

Replace the existing float comparison wrapper in the Take Orders SDK with a direct comparison function from the float library.

Context

The Take Orders SDK currently uses a custom wrapper that composes the float type's less_than and greater_than functions to perform comparisons. A comparison function that returns Rust's Ordering type (Greater, Less, Equal) should be implemented directly in the float library, as this logic belongs with the float type itself.

Steps

  1. Implement a comparison function in the float library that returns Ordering
  2. Update the Take Orders SDK in this repo to use the new library function
  3. Remove the existing comparison wrapper

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions