Repository navigation
Conversation
Currently, the `yfinance` package includes an executable shim named `sample`. As this executable shim wraps a non-existent module, this was likely added in error. Given that this executable serves no purpose, as a small item of clean-up, the following change drops this executable from the set of installed artifacts.
Author
|
While the packaging behavior is well documented and thus, the side-effects of this change should be self-evident, if only to provide some added confidence, please find below some test evidence to support this change: BeforeAfter |
kyleoraa
marked this pull request as ready for review
June 3, 2026 22:09
Collaborator
|
@ranaroussi This was your first commit |
Author
While I did not want to get too speculative in the commit message, I did observe this as well. Given the similar structure, I strongly suspect it is merely a remnant of the template made available by PyPA around that time. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
yfinancepackage includes an executable shim namedsample. As this executable shim wraps a non-existent module, this was likely added in error. Given that this executable serves no purpose, as a small item of clean-up, the following change drops this executable from the set of installed artifacts.