Added cooling relay and heater rework#477
Open
DanieleNeo wants to merge 3 commits intoraomin:mainfrom
Open
Conversation
raomin
reviewed
Dec 11, 2024
Owner
raomin
left a comment
There was a problem hiding this comment.
Thanks for this. Please review suggestions.
Can you also adjust Readme?
Pull request suggestion receipted Co-authored-by: Raomin <4460208+raomin@users.noreply.github.com>
Pull request suggestion receipted Co-authored-by: Raomin <4460208+raomin@users.noreply.github.com>
Author
|
Hi @raomin, I reviewed your suggestion. For the readme I can do it, but not at the moment (lack of time)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @raomin,
I made a little rework in order to add also the cooler thermostat relay, with heater at higher priority, as discussed here #467
Hoping to have done something appreciated
Sincerely,
D.