feat(reader): add 'view original' button for local comics#123
Draft
wellorbetter wants to merge 1 commit into
Draft
feat(reader): add 'view original' button for local comics#123wellorbetter wants to merge 1 commit into
wellorbetter wants to merge 1 commit into
Conversation
wellorbetter
changed the title
… to online detail page When reading a downloaded comic, a new button appears in the reader's AppBar that navigates to the comic's online detail page. Closes raoxwup#119
wellorbetter
force-pushed
the
feat/download-navigate-to-details
branch
from
01da3c9 to
690562e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a "view original" button to the reader AppBar when reading downloaded (local) comics, allowing users to navigate back to the online comic detail page.
Closes #119
Reasoning
Users who download many comics have no way to navigate back to the original comic's online detail page from the reader. This adds a single conditional button that only appears for local comics (
ReaderType.local), keeping the reader clean for online and imported comics.Key design decisions:
context.selectormatching existing AppBar field access styleDownloadComic.idis the same value passed fromComicDetails.comicIdat download time, so/details/$comicIdroutes correctlyChanges
Modified files (1):
app_bar.dart— Addcomic_state.dartimport, readtype/idfrom provider, conditionally renderIconButtonwithIcons.open_in_newforReaderType.localType of change