Replace isort with ruff for import sorting#239
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 29 29
Lines 1843 1843
=======================================
Hits 1720 1720
Misses 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes isort and switches import sorting to Ruff’s built-in isort rules.
Changes:
- Remove
isortfrom thedevoptional dependency set and fromuv.lock. - Enable Ruff’s import-sorting rules (
I) and migrateisortconfiguration into[tool.ruff.lint.isort]. - Update
code_check.pyto stop runningisortas a separate step.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
uv.lock |
Removes isort from the resolved dev environment and updates the pinned Ruff version. |
pyproject.toml |
Drops isort from dev extras and configures Ruff to handle import sorting (including Django sectioning). |
code_check.py |
Removes the explicit isort invocation so Ruff is the single import-sorting mechanism. |
Comments suppressed due to low confidence (1)
pyproject.toml:41
uv.lockpins ruff to 0.15.9, but the dev extra still allowsruff >= 0.15.7. Since this PR adds ruff-isort configuration (customsection-order/sections), using an older allowed ruff version may fail to parse the config or behave differently for contributors installing viapip -e .[dev]. Consider bumping the minimum dev requirement toruff >= 0.15.9(or whatever minimum version is required for this config).
[project.optional-dependencies]
dev = [
"colorama >= 0.4.3",
"coverage[toml] >= 7.2.2",
"ruff >= 0.15.7",
"djlint >= 1.34.1",
]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.