Skip to content

Conversation

@aamijar
Copy link
Member

@aamijar aamijar commented Feb 4, 2026

The lanczos SM gtests are consistenly flaky on CUDA 13.1 in CI SOLVERS_TEST. The SM option was never truly stable to begin with and was actually omitted in the pytests test_sparse.py but it seems that it was never removed from the gtests. It would make sense to comment these gtests out and reference this issue instead #2705.

Update: only disable the SM gtest for cuda 13.1

@aamijar aamijar requested a review from a team as a code owner February 4, 2026 00:30
@aamijar aamijar self-assigned this Feb 4, 2026
@aamijar aamijar added bug Something isn't working non-breaking Non-breaking change labels Feb 4, 2026
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is only flaky in 13.1, let's only skip it in that case. If this is a feature that users can use today, we shouldn't be removing tests just because they are flaky. Instead we should be working to fix the issue. Or at the very leas, only skip the tests under the circumstances by which they are flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Development

Successfully merging this pull request may close these issues.

2 participants