GetExtractInterfaceOptions change in dotnet 10

[alsi-lawr]

Dotnet 10

    ExtractInterfaceOptionsResult GetExtractInterfaceOptions(
        Document document,
        ImmutableArray<ISymbol> extractableMembers,
        string defaultInterfaceName,
        ImmutableArray<string> conflictingTypeNames,
        string defaultNamespace,
        string generatedNameTypeParameterSuffix);

Dotnet 9

    ExtractInterfaceOptionsResult GetExtractInterfaceOptions(
        ISyntaxFactsService syntaxFactsService,
        INotificationService notificationService,
        List<ISymbol> extractableMembers,
        string defaultInterfaceName,
        List<string> conflictingTypeNames,
        string defaultNamespace,
        string generatedNameTypeParameterSuffix,
        string languageName,
        CancellationToken cancellationToken);

Similar to a previous issue I'd contributed to, happy to contribute again.

[razzmatazz]

Please, feel free to

[alsi-lawr]

Please, feel free to

is main in a working state? I can't currently build

Restore complete (3.4s)
  CSharpLanguageServer net9.0 failed with 1 error(s) (6.9s)
    /mnt/g/csharp-language-server/src/CSharpLanguageServer/Handlers/Completion.fs(83,30): error FS3397: This expression uses 'unit' for an 'obj'-typed argument. This will lead to passing 'null' at runtime. This warning may be disabled using '#nowarn "3397".

Edit: Nevermind, it's because it was building with dotnet 10, which has tightened up its analysers for this dotnet/fsharp#18330

[alsi-lawr]

@razzmatazz I believe this work is blocked by an upgrade to dotnet 10, which does not seem to be a trivial task

[razzmatazz]

could very well be. i did not invest time into .net 10 yet

[razzmatazz]

I bumped .NET sdk to 10 in #281 (but did not bump Roslyn libs)

Roslyn libs have been updated to 5.0.0 as well

[alsi-lawr]

I bumped .NET sdk to 10 in #281 (but did not bump Roslyn libs)

Roslyn libs have been updated to 5.0.0 as well

Wonderful, I'll pick up this fix after work today