feat: Add onOpenMenu and onCloseMenu event handlers #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inshallah
Add onMenuClose event that fires when menu is dismissed. - Implement for both iOS and Android platforms - Add event at start of dismissal for better responsiveness - Support both old and new React Native architectures - Add tests and update documentation The event fires when: - User taps outside the menu - User selects a menu item
…ndefined event parameter
…t string event parameters
Contributor
|
@Naturalclar would be awesome to have |
Naturalclar
approved these changes
Dec 27, 2024
Member
Naturalclar
left a comment
Naturalclar
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added menu open/close event handlers
This PR adds two new events -
onOpenMenuandonCloseMenu- so you can track when the menu appears and disappears. This is useful for analytics, UI state management, and accessibility features.Works across both platforms:
Added TypeScript types and docs for the new events. Let me know if anything needs tweaking!
Test Plan
Manual Testing
Test Scenarios
shouldOpenOnLongPress={true})#Inspiration
While working with menus in FlatList, I ran into the same issue as #334 where tapping to dismiss the menu would trigger unwanted tap events on the underlying FlatList. To solve this, I added
onOpenMenuandonCloseMenuevents so developers can better control interactions during menu state changes.