Skip to content

Update eslint comment#1845

Closed
foxyblocks wants to merge 1 commit into
react:masterfrom
foxyblocks:update-eslint-comment
Closed

Update eslint comment#1845
foxyblocks wants to merge 1 commit into
react:masterfrom
foxyblocks:update-eslint-comment

Conversation

@foxyblocks
Copy link
Copy Markdown

This comment is no longer accurate.

@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Timer Timer added this to the 0.9.6 milestone Mar 20, 2017
@Timer
Copy link
Copy Markdown
Contributor

Timer commented Apr 15, 2017

I appreciate the pull request, however, I think this update is unnecessarily verbose.
Even if we use error, it's for actual errors -- there's no reason to say "we show errors for errors."

It's more important to express that we don't use error for something that might be an error, which I believe the current comment does sufficiently.

If you have an objection, please feel free to voice it. I'm not opposed to merging this in some form, but with different wording (unless if what I said makes sense).

@Timer Timer closed this Apr 15, 2017
@lock lock Bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants