Generalized Solution for avoiding Out-of-Order Cache Child ChangeSets#1009
Merged
dwcullop merged 12 commits intoreactivemarbles:mainfrom May 28, 2025
Merged
Conversation
dwcullop
changed the title
JakenVeina
approved these changes
May 28, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a follow up to #1007, I looked for other operators that are handling Remove/Update changes as a separate step and found that
MergeManyChangeSetshas a similar defect (as shown by the newly included unit test).This PR introduces a base class that implements the general solution for handling a parent changeset where each item owns a child subscription and then it adapts existing operators to use it:
I think that is all of them for Cache. The List versions of the MergeManyChangeSets have a similar issue, but I will need to make a List version of
CacheParentSubcription, so I will address that in another PR.