Merged
Conversation
…on where implicit casting of a generic is in play. The expression compiles differently depending on whether the generic type in question is a value type, versus a reference type, and generates an excpetion in the case of a value type.
dwcullop
approved these changes
Aug 16, 2024
Member
dwcullop
left a comment
dwcullop
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this so quickly.
erri120
added a commit
to erri120/NexusMods.App
that referenced
this pull request
Aug 28, 2024
Contains reactivemarbles/DynamicData#926 and other fixes.
erri120
added a commit
to erri120/NexusMods.App
that referenced
this pull request
Aug 29, 2024
Contains reactivemarbles/DynamicData#926 and other fixes.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bogus use of the
defaultkeyword, within a ternary expression where implicit casting of a generic is in play. The expression compiles differently depending on whether the generic type in question is a value type, versus a reference type, and generates an exception in the case of a value type.