Typescript support section: mention server_renderer_extensions#1054
Merged
BookOfGreg merged 1 commit intoreactjs:masterfrom May 12, 2020
Merged
Typescript support section: mention server_renderer_extensions#1054BookOfGreg merged 1 commit intoreactjs:masterfrom
BookOfGreg merged 1 commit intoreactjs:masterfrom
Conversation
Recommend setting the `server_renderer_extensions` config option.
Member
|
In the docs you present it as a recommendation, I appreciate that as the user always has choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend setting the
server_renderer_extensionsconfig option in the Typescript support section.I experienced issues with changes to
tsxandtsfiles not being properly updated in development. After loads of research on various levels of setup, I ran into this issue, which thankfully had a fix (I felt equally stupid as the author). I'd say typescript support is incomplete without theserver_renderer_extensionsconfig. Anything else delivers a subpar development experience.I hope you sill consider my addition to the README, and thanks for all the work you put into this lib 👍