Close modal when clicked on overlay or 'Escape' button is pressed#202
Merged
atapas merged 1 commit intoreactplay:mainfrom May 19, 2022
Merged
Close modal when clicked on overlay or 'Escape' button is pressed#202atapas merged 1 commit intoreactplay:mainfrom
atapas merged 1 commit intoreactplay:mainfrom
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @atapas on Vercel. @atapas first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atapas
approved these changes
May 19, 2022
Member
atapas
left a comment
There was a problem hiding this comment.
@Shriom-Trivedi Looks good to me.
|
@Shriom-Trivedi looks good👍 |
Member
|
@all-contributors please add @Shriom-Trivedi for Code |
Contributor
|
I've put up a pull request to add @Shriom-Trivedi! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue[feature request]: The filter modal should be closed when Esc button is pressed or when the modal container is clicked.
Fixes #195
Type of change
solution: Added onClose method on modal-overlay which sets useState showModal's value to false. For binding escape button, I've added a event listner in useEffect which checks whether Esc button is pressed or not and if pressed it sets showModal to false.
Please delete options that are not relevant.
How Has This Been Tested?
I've done some manual testing and it's working fine.
Checklist: