Skip to content

Comments

fix(image): force SVG dimensions in lightbox#734

Merged
rafegoldberg merged 1 commit intonextfrom
fix/image/svg-dimensions-in-lightbox
Apr 10, 2023
Merged

fix(image): force SVG dimensions in lightbox#734
rafegoldberg merged 1 commit intonextfrom
fix/image/svg-dimensions-in-lightbox

Conversation

@rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Apr 5, 2023 •
edited
Loading

📖 PR App 🎫 Fix CX-217

🧰 Changes

SVGs weren't displaying at all when shown in the lightbox. (For example, try clicking on the first image here.)

  • override dimensions for lightboxed SVG images

🧬 QA & Testing

🚧 Note: we'll need to cut a new release and merge this in to ReadMe to fully test.

@rafegoldberg rafegoldberg added bug Something isn't working styles Changes related to visual styling labels Apr 5, 2023
@rafegoldberg rafegoldberg requested review from a team, kellyjosephprice, mosesj-readme and thenaomiday and removed request for a team April 5, 2023 10:32
@github-actions
Copy link

github-actions bot commented Apr 5, 2023 •
edited
Loading

A review app has been launched for this PR!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-734

🧭 Take it for a spin: https://markdown-pr-734.herokuapp.com/

  • Shut down on Mon Apr 10: Since this PR is closed, its review app has been cleaned up. 🧽

@rafegoldberg rafegoldberg merged commit 71fc4e5 into next Apr 10, 2023
@rafegoldberg rafegoldberg deleted the fix/image/svg-dimensions-in-lightbox branch April 10, 2023 16:46
rafegoldberg pushed a commit that referenced this pull request Apr 14, 2023
@semantic-release-bot
build(release): 🚀 v6.61.1 🦉
e908832 
## Version 6.61.1

### 🛠 Fixes & Updates

* centering in firefox ([#721](#721)) ([6a62281](6a62281))
* **image:** force SVG dimensions in lightbox ([#734](#734)) ([71fc4e5](71fc4e5))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

rafegoldberg commented Apr 14, 2023

This PR was released!

🚀 Changes included in v6.61.1

rafegoldberg pushed a commit that referenced this pull request Nov 4, 2025
@semantic-release-bot
build(release): 🚀 v11.5.2 🦉
eac8fc2 
## Version 11.5.2
### 🛠 Fixes & Updates

* **deps:** bump actions/upload-artifact from 4 to 5 ([#1224](#1224)) ([698390a](698390a)), closes [actions/upload-artifact#681](actions/upload-artifact#681) [actions/upload-artifact#712](actions/upload-artifact#712) [actions/upload-artifact#727](actions/upload-artifact#727) [actions/upload-artifact#725](actions/upload-artifact#725) [actions/upload-artifact#734](actions/upload-artifact#734) [actions/upload-artifact#681](actions/upload-artifact#681) [actions/upload-artifact#712](actions/upload-artifact#712) [actions/upload-artifact#727](actions/upload-artifact#727) [actions/upload-artifact#725](actions/upload-artifact#725) [actions/upload-artifact#685](actions/upload-artifact#685) [actions/upload-artifact#685](actions/upload-artifact#685) [actions/upload-artifact#673](actions/upload-artifact#673) [actions/upload-artifact#662](actions/upload-artifact#662) [actions/upload-artifact#578](actions/upload-artifact#578) [actions/upload-artifact#656](actions/upload-artifact#656) [actions/upload-artifact#578](actions/upload-artifact#578) [#734](#734) [#725](#725) [#727](#727) [#712](#712)
* migration erroring when there is empty cell in table ([#1223](#1223)) ([227cbb4](227cbb4))

<!--SKIP CI-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thenaomiday thenaomiday Awaiting requested review from thenaomiday

@mosesj-readme mosesj-readme Awaiting requested review from mosesj-readme mosesj-readme was automatically assigned from readmeio/engineers

1 more reviewer

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working released styles Changes related to visual styling

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rafegoldberg @kellyjosephprice