-
-
Notifications
You must be signed in to change notification settings - Fork 430
Bump to PHPStan 2.1.34 and fix compatible code #7844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@TomasVotruba it seems there is error on ContainerMemento after update to PHPStan 2.1.34 PHP Warning: Undefined array key 0 in /home/runner/work/rector-src/rector-src/src/DependencyInjection/PHPStan/PHPStanContainerMemento.php on line 44 |
3d693a2 to
3449037
Compare
7d8b43f to
30c7501
Compare
7fe9647 to
ecc834b
Compare
|
@TomasVotruba ready for merge 👍 the notice on |
MGatner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
LGTM 👌 |
|
Released immediate rector 2.3.2 for it :) https://github.com/rectorphp/rector/releases/tag/2.3.2 |
the change:
VariadicFunctionsVisitorandVariadicMethodsVisitorPHPStan\Analyser\Fiber\FiberScope, need to be converted to:on
PHPStanNodeScopeResolverand on use of$scope->getParentScope()OptimizedSingleFileSourceLocatorneed to be created viaOptimizedSingleFileSourceLocatorRepositoryFixes rectorphp/rector#9604