Feature: use curl (or whatever else) as HttpAdapter#675
Open
SinusPi wants to merge 22 commits intorecurly:v3-v2021-02-25from
Open
Feature: use curl (or whatever else) as HttpAdapter#675SinusPi wants to merge 22 commits intorecurly:v3-v2021-02-25from
SinusPi wants to merge 22 commits intorecurly:v3-v2021-02-25from
Conversation
- Base client class now accepts Http Adapter object as param. - Add http adapter interface
… into v3-v2021-02-25: - Added HttpAdapterInterface
…t-Type: application/json" was received in header.
so that makeRequest AND pagerCount are validated.
… because toResource no longer throws errors - makeRequest does.
…sPi/recurly-client-php into v3-v2021-02-25--httpadapter
…d with env vars, skipped by default.
…yError, just a ConnectionError that inherits \Error, bearing full curlinfo inside.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added curl as a more configurable HTTP connection library.
(Includes: saas786's HttpAdapterInterface patch, plus HEAD request validity check patch. May not need the latter.)
Primary improvement: if curl fails to connect, it throws a \Recurly\ConnectionError with all of its curl_getinfo in it, ready for implementing possible retries, network outage reports, etc.
Before: if file_get_contents fails to connect, it emits a PHP Warning in text and returns an empty response, with not a lot of error-handling possible.
A test case verifies curl's connection abilities, using live API (obviously impure; enable test with an env var if needed).