Add noobaa storage class to the list that can be disribute#3729
Conversation
|
Hi @shirady. Thanks for your PR. I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rewantsoni, @leelavg please take a look |
|
LGTM |
|
@nb-ohad , please take a look |
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
76231d3 to
0721f4b
Compare
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nb-ohad, shirady The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
30c9e5a
into
red-hat-storage:main
Describe the problem
Part of RHSTOR-6230
As part of testing red-hat-storage/ocs-client-operator#520 noticed that I don't have the noobaa storage class needed for OBCs.
Explain the changes
StorageClassFromExisting.https://github.com/noobaa/noobaa-operator/blob/f993b9b1ae24d1e32e37d1e15a3a4a77f0529f97/pkg/options/options.go#L209-L217
Note: I planned to squash the commits, but it was merged before I did it.
Testing Instructions:
Manual Tests:
In the provider cluster:
oc edit storageconsumer -n openshift-storage <storage-consumer-name>before:
after (added it last in the list):
In the client cluster:
3. Wait for 2 minutes and check that the storageclass was added:
oc get storageclass(expect to see in the table:openshift-storage.noobaa.io).Note - I also tested it with an additional created storageclass (difference in name only), for example: