Skip to content

Add noobaa storage class to the list that can be disribute#3729

Merged
openshift-merge-bot[bot] merged 6 commits intored-hat-storage:mainfrom
shirady:add-noobaa-storage-class
Mar 17, 2026
Merged

Add noobaa storage class to the list that can be disribute#3729
openshift-merge-bot[bot] merged 6 commits intored-hat-storage:mainfrom
shirady:add-noobaa-storage-class

Conversation

@shirady
Copy link
Copy Markdown
Contributor

@shirady shirady commented Mar 8, 2026

Describe the problem

Part of RHSTOR-6230
As part of testing red-hat-storage/ocs-client-operator#520 noticed that I don't have the noobaa storage class needed for OBCs.

Explain the changes

  1. Add noobaa storage class in the function StorageClassFromExisting.
  2. Noobaa storage class name derived from the following:
    https://github.com/noobaa/noobaa-operator/blob/f993b9b1ae24d1e32e37d1e15a3a4a77f0529f97/pkg/options/options.go#L209-L217
  3. For the namespace, add an env in the deployment of OCS Provider Server, and fix a test accordingly.

Note: I planned to squash the commits, but it was merged before I did it.

Testing Instructions:

Manual Tests:

In the provider cluster:

  1. Edit the storage consumer CR: oc edit storageconsumer -n openshift-storage <storage-consumer-name>
  2. Add noobaa storage class to the list:
    before:
  storageClasses:
  - name: ocs-storagecluster-ceph-rbd
  - name: ocs-storagecluster-cephfs

after (added it last in the list):

  storageClasses:
  - name: ocs-storagecluster-ceph-rbd
  - name: ocs-storagecluster-cephfs
  - name: openshift-storage.noobaa.io

In the client cluster:
3. Wait for 2 minutes and check that the storageclass was added: oc get storageclass (expect to see in the table: openshift-storage.noobaa.io).

Note - I also tested it with an additional created storageclass (difference in name only), for example:

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: openshift-storage.noobaa.io-02
parameters:
  bucketclass: noobaa-default-bucket-class
provisioner: openshift-storage.noobaa.io/obc
reclaimPolicy: Delete
volumeBindingMode: Immediate

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 8, 2026

Hi @shirady. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shirady
Copy link
Copy Markdown
Contributor Author

shirady commented Mar 8, 2026

@rewantsoni, @leelavg please take a look

Comment thread controllers/util/storageclasses.go Outdated
@rewantsoni
Copy link
Copy Markdown
Member

LGTM

@shirady
Copy link
Copy Markdown
Contributor Author

shirady commented Mar 12, 2026

@nb-ohad , please take a look

Comment thread controllers/util/storageclasses.go Outdated
Comment thread controllers/util/storageclasses.go
shirady added 4 commits March 17, 2026 16:51
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady force-pushed the add-noobaa-storage-class branch from 76231d3 to 0721f4b Compare March 17, 2026 14:54
shirady added 2 commits March 17, 2026 17:11
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@nb-ohad
Copy link
Copy Markdown
Contributor

nb-ohad commented Mar 17, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nb-ohad, shirady

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 30c9e5a into red-hat-storage:main Mar 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants