rectify health score to count only unique alerts#3732
rectify health score to count only unique alerts#3732yati1998 wants to merge 1 commit intored-hat-storage:mainfrom
Conversation
Currentyl the health score calculation counts 3 different alerts for node latency on different nodes which is not required. This commit rectifies that error and counts only unique alert names Signed-off-by: yati1998 <ypadia@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yati1998 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Added 2 screenshots that show the PR is working correctly. Even if the alert for nodes was ended, it was counting on it and additionally, it was counting alerts for 3 different nodes separately. Now it is resolved with this change. |
| continue | ||
| } | ||
|
|
||
| seenAlerts[alertName] = severity |
There was a problem hiding this comment.
Do we need to store the severity as it is not being accessed anywhere?
2 participants
Currentyl the health score calculation counts 3
different alerts for node latency on different
nodes which is not required.
This commit rectifies that error and counts
only unique alert names