Conversation
tasks/setup_registry.yaml
Outdated
|
|
||
| - name: Mirror the registry | ||
| when: setup_registry.autosync_registry | ||
| when: setup_registry.autosync_registry and sig_output |
There was a problem hiding this comment.
Why and sig_output this would fail on 4.20 and earlier versions.
tasks/setup_registry.yaml
Outdated
| --force=false | ||
| register: sig_output |
There was a problem hiding this comment.
--continue-on-error should be added so this works across release.
| shell: | | ||
| oc adm release info | grep Digest: | awk '{print $2}' | sed 's/:/-/g' | ||
| register: RELEASE_DIGEST |
There was a problem hiding this comment.
| shell: | | |
| oc adm release info | grep Digest: | awk '{print $2}' | sed 's/:/-/g' | |
| register: RELEASE_DIGEST | |
| shell: | | |
| oc adm release info | grep Digest: | awk '{print $2}' | sed 's/:/-/g' | |
| register: RELEASE_DIGEST |
Needless space in command
You need to use L126 https://github.com/redhat-cop/ocp4-helpernode/blob/main/tasks/setup_registry.yaml#L126 rather than the current approach in the PR
~hum... how does this work with nightly build? You can download openshift-installer at https://openshift-release-artifacts-ppc64le.apps.ci.l2s4.p1.openshiftapps.com/4.22.0-0.nightly-ppc64le-2026-02-12-194353
And see what openshift-installer outputs.
We might need to check ~
mpkredhat
force-pushed
the
br-sigstore
branch
2 times, most recently
from
23e4273 to
8db2eda
Compare
|
Left offline comments |
mpkredhat
force-pushed
the
br-sigstore
branch
from
8db2eda to
bfc9599
Compare
tasks/main.yml
Outdated
| - name: Copy mirror-isc.yaml | ||
| copy: | ||
| src: ../templates/mirror-isc.yaml.j2 | ||
| dest: /usr/local/src/mirror-isc.yaml | ||
| mode: "0655" | ||
| owner: root | ||
| group: root |
There was a problem hiding this comment.
Let's save this for a different PR...
mpkredhat
changed the title
mpkredhat
changed the title
mpkredhat
changed the title
Signed-off-by: Mandar Kulkarni <mandar.kulkarni6@ibm.com>
3 participants
This PR mirrors the
sigfile required in disconnected installations.This step is part of disconnected changes to get inline with current mirroring best practices.
Corresponding Redhat issue : https://issues.redhat.com/browse/OCPBUGS-70297