Skip to content

Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46' #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgwest merged 3 commits into from
Mar 2, 2026
Merged

Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e331238ec9f602809537ab4' and argocd-operator '0433a07294f89d858bc88192f9b96155985cec46' #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c4d93
Update to latest commit of argo-rollouts-manager '1824164aac67c5eb8e3…
jgwest Feb 24, 2026
03d5007
fix: update expected metric plugin configmap name and sha256 value
jgwest Feb 24, 2026
8cc13c9
chore: update to latest argocd-operator
jgwest Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions bundle/manifests/argoproj.io_argocds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11358,6 +11358,13 @@ spec:
description: Agent defines configurations for the Agent component
of Argo CD Agent.
properties:
allowedNamespaces:
description: |-
AllowedNamespaces is a list of additional namespaces the agent is allowed to
manage applications in. Supports glob patterns.
items:
type: string
type: array
client:
description: Client defines the client options for the Agent
component.
Expand Down Expand Up @@ -11392,6 +11399,20 @@ spec:
description: Creds is the credential identifier for the agent
authentication
type: string
destinationBasedMapping:
description: DestinationBasedMapping defines the options for
destination based mapping for the Agent component.
properties:
createNamespace:
description: |-
CreateNamespace enables automatic creation of target namespaces on the managed cluster
when destination-based mapping is enabled.
type: boolean
enabled:
description: Enabled is the flag to enable destination
based mapping for the Agent component.
type: boolean
type: object
enabled:
description: Enabled is the flag to enable the Agent component
during Argo CD installation. (optional, default `false`)
Expand Down Expand Up @@ -11600,6 +11621,10 @@ spec:
description: Auth is the authentication method for the Principal
component.
type: string
destinationBasedMapping:
description: DestinationBasedMapping is the flag to enable
destination based mapping for the Principal component.
type: boolean
enabled:
description: Enabled is the flag to enable the Principal component
during Argo CD installation. (optional, default `false`)
Expand Down
2 changes: 1 addition & 1 deletion bundle/manifests/gitops-operator.clusterserviceversion.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ metadata:
capabilities: Deep Insights
console.openshift.io/plugins: '["gitops-plugin"]'
containerImage: quay.io/redhat-developer/gitops-operator
createdAt: "2026-02-25T05:56:01Z"
createdAt: "2026-02-27T08:17:37Z"
description: Enables teams to adopt GitOps principles for managing cluster configurations
and application delivery across hybrid multi-cluster Kubernetes environments.
features.operators.openshift.io/disconnected: "true"
Expand Down
25 changes: 25 additions & 0 deletions config/crd/bases/argoproj.io_argocds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11347,6 +11347,13 @@ spec:
description: Agent defines configurations for the Agent component
of Argo CD Agent.
properties:
allowedNamespaces:
description: |-
AllowedNamespaces is a list of additional namespaces the agent is allowed to
manage applications in. Supports glob patterns.
items:
type: string
type: array
client:
description: Client defines the client options for the Agent
component.
Expand Down Expand Up @@ -11381,6 +11388,20 @@ spec:
description: Creds is the credential identifier for the agent
authentication
type: string
destinationBasedMapping:
description: DestinationBasedMapping defines the options for
destination based mapping for the Agent component.
properties:
createNamespace:
description: |-
CreateNamespace enables automatic creation of target namespaces on the managed cluster
when destination-based mapping is enabled.
type: boolean
enabled:
description: Enabled is the flag to enable destination
based mapping for the Agent component.
type: boolean
type: object
enabled:
description: Enabled is the flag to enable the Agent component
during Argo CD installation. (optional, default `false`)
Expand Down Expand Up @@ -11589,6 +11610,10 @@ spec:
description: Auth is the authentication method for the Principal
component.
type: string
destinationBasedMapping:
description: DestinationBasedMapping is the flag to enable
destination based mapping for the Principal component.
type: boolean
enabled:
description: Enabled is the flag to enable the Principal component
during Argo CD installation. (optional, default `false`)
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ module github.com/redhat-developer/gitops-operator
go 1.25.5

require (
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce417a
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260224121037-1824164aac67
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260227080902-0433a07294f8
github.com/argoproj/argo-cd/v3 v3.3.0
github.com/argoproj/gitops-engine v0.7.1-0.20251217140045-5baed5604d2d
github.com/go-logr/logr v1.4.3
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@ github.com/alicebob/miniredis/v2 v2.35.0/go.mod h1:TcL7YfarKPGDAthEtl5NBeHZfeUQj
github.com/anmitsu/go-shlex v0.0.0-20200514113438-38f4b401e2be h1:9AeTilPcZAjCFIImctFaOjnTIavg87rW78vTPkQqLI8=
github.com/anmitsu/go-shlex v0.0.0-20200514113438-38f4b401e2be/go.mod h1:ySMOLuWl6zY27l47sB3qLNK6tF2fkHG55UZxx8oIVo4=
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce417a h1:USjEzxbs2lZtx7+Hp9u5dYgu7pf/9XnDUSc9+Hmulmo=
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260218104514-432c01ce417a/go.mod h1:WPyZkNHZjir/OTt8mrRwcUZKe1euHrHPJsRv1Wp/F/0=
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260224121037-1824164aac67 h1:gFasfvlbOfrwzd7JaVTlnRgE7pDMFC+lQwt07gGGrbY=
github.com/argoproj-labs/argo-rollouts-manager v0.0.8-0.20260224121037-1824164aac67/go.mod h1:WPyZkNHZjir/OTt8mrRwcUZKe1euHrHPJsRv1Wp/F/0=
github.com/argoproj-labs/argocd-image-updater v1.1.1 h1:7YDaR3WX2NMsDKp0wN7TRaRRHaVHQ94tSybi2P99MGk=
github.com/argoproj-labs/argocd-image-updater v1.1.1/go.mod h1:gMHiNrGNwNSt4ljf0ykcnmNvXBk/NJ+Z17AnZVe7V7I=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94 h1:1HO3tG4kb0rJ2XD+pjHlSLbZMufBl/fNqGhkf9vkpho=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260225142026-dabb25d60d94/go.mod h1:3/Y9YWMU+DHC+onOQVXPAxrNkoBAGZD+UQui9BgJBjY=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260227080902-0433a07294f8 h1:MZH+YNGfucyny7tX2Fs4aNNQgeOuu9Gi7MtjS3L4R1U=
github.com/argoproj-labs/argocd-operator v0.17.0-rc1.0.20260227080902-0433a07294f8/go.mod h1:3/Y9YWMU+DHC+onOQVXPAxrNkoBAGZD+UQui9BgJBjY=
github.com/argoproj/argo-cd/v3 v3.3.0 h1:9UlruTd5cC/MyvorTXgAIblfZTy63MF5FYvvoAaUvwU=
github.com/argoproj/argo-cd/v3 v3.3.0/go.mod h1:5VAfe0s/a4VY5GmAIFK76FtW6xn7zAcLmaw25bOL/2g=
github.com/argoproj/gitops-engine v0.7.1-0.20251217140045-5baed5604d2d h1:iUJYrbSvpV9n8vyl1sBt1GceM60HhHfnHxuzcm5apDg=
Expand Down
2 changes: 1 addition & 1 deletion scripts/run-rollouts-e2e-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ cd "$ROLLOUTS_TMP_DIR/argo-rollouts-manager"

# This commit value will be automatically updated by calling 'hack/upgrade-rollouts-manager/go-run.sh':
# - It should always point to the same argo-rollouts-manager commit that is referenced in go.mod of gitops-operator (which will usually be the most recent argo-rollouts-manager commit)
TARGET_ROLLOUT_MANAGER_COMMIT=432c01ce417a25503ce2f57b9e46362bef4b75c7
TARGET_ROLLOUT_MANAGER_COMMIT=1824164aac67c5eb8e331238ec9f602809537ab4

# This commit value will be automatically updated by calling 'hack/upgrade-rollouts-manager/go-run.sh':
# - It should always point to the same argo-rollouts-manager commit that is referenced in the version of argo-rollouts-manager that is in go.mod
Expand Down
6 changes: 3 additions & 3 deletions test/openshift/e2e/ginkgo/sequential/1-112_validate_rollout_plugin_support_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ var _ = Describe("GitOps Operator Sequential E2E Tests", func() {
{
Name: "argoproj-labs/sample-prometheus",
Location: "https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64",
SHA256: "dac10cbf57633c9832a17f8c27d2ca34aa97dd3d",
SHA256: "af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767",
Copy link
Copy Markdown

@ranakan19 ranakan19 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different sha length here stands out to me, is this intentional?
also the sha is different from argoproj-labs/argo-rollouts-manager@1824164

Copy link
Copy Markdown
Member Author

@jgwest jgwest Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old value was invalid (it's not even the right length for sha256 😅 ), but because the argo rollouts manager code wasn't properly applying the SHA to the ConfigMap, it wasn't caught by the test.

The current value is the new, correct value; you can verify manually by downloading the binary and running sha256sum "(downloaded binary from url)" (IIRC sha256sum only works on Linux, but mac os has an equivalent)

},
},
},
Expand Down Expand Up @@ -132,10 +132,10 @@ var _ = Describe("GitOps Operator Sequential E2E Tests", func() {
},
}
Eventually(rolloutsConfigMap).Should(k8sFixture.ExistByName())
Eventually(rolloutsConfigMap).Should(configmap.HaveStringDataKeyValue("metricPlugins", `
Eventually(rolloutsConfigMap).Should(configmap.HaveStringDataKeyValue("metricProviderPlugins", `
- name: argoproj-labs/sample-prometheus
location: https://github.com/argoproj-labs/sample-rollouts-metric-plugin/releases/download/v0.0.4/metric-plugin-linux-amd64
sha256: dac10cbf57633c9832a17f8c27d2ca34aa97dd3d`))
sha256: af83581a496cebad569c6ddca4e1b7beef1c6f51573d6cd235cebe4390d3a767`))
Copy link
Copy Markdown

@ranakan19 ranakan19 Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here

Copy link
Copy Markdown
Member Author

@jgwest jgwest Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, same as above, the new value is the actual correct value (no idea what the provenance of the old value was)


By("verifying the trafficRouterPlugin contains both gatewayAPI, AND our openshift route plugin")

Expand Down