Skip to content

feat: add support for adding labels to self hosted runner #324

Merged
anjannath merged 2 commits into
redhat-developer:mainfrom
anjannath:issue_320
Nov 6, 2024
Merged

feat: add support for adding labels to self hosted runner #324
anjannath merged 2 commits into
redhat-developer:mainfrom
anjannath:issue_320

Conversation

@anjannath
Copy link
Copy Markdown
Collaborator

fixes #320

when the required flags like `ghactions-runner-{token, name, url}`
have an empty value error should be fatal as without these values
machine cannot be setup as a self hosted runner.

earlier the `mapt` command would continue even when these flags
were empty and resulted into a machine being provisioned but not
added as a self-hosted runner
this adds a new flag `--ghactions-runner-labels` that takes a string
slice containing the desired labels to be added to the action runner

e.g `--ghactions-runner-labels="azure,mapt,win,self-hosted"` these
labels would be added in addition to the default labels already added
by the runner agent
Copy link
Copy Markdown
Collaborator

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@anjannath anjannath merged commit 1b9bc0d into redhat-developer:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[task] provide flag to set tags on the self-hosted runner

2 participants