Fixes / Improvements around aws spot provisioning#566
Merged
Conversation
Collaborator
Author
|
Ok...only took me 2 days ..read this right and undestand it was about AWS ...not Azure...this is a regression b/c of the heavy refactor I did in these modules. ^^@lilyLuLiu When the image for this PR is built can you test it? and add comment here? |
Due to refactor on compute-request selector the value for nested virtualization was missing when filtering machines. Then even when the flag was used the type of machines returned are not taking it into consideration. This commit ensures the value is pass again in the filter. Fix redhat-developer#563. Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Collaborator
Author
|
@lilyLuLiu wait for testing this, I need to change something else, it is not working ATM. Will let you know |
adrianriobo
changed the title
Collaborator
Author
|
@lilyLuLiu now it should be good to test (once the checks are finished you should be able to get the image from ghcr) |
psturc
approved these changes
Aug 8, 2025
Collaborator
psturc
left a comment
psturc
left a comment
There was a problem hiding this comment.
lgtm, tested with kind-aws-provision tekton task
…pot module Previously the instance types used while requesting spot instances for AWS were out of sync with values calculated on spot. This was causing lots of issues with discrepancy between types and prices on spot. This commit ensures the types are coming from calculated prices on spot. Fix redhat-developer#567. Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Collaborator
|
verified the latest update 👍 |
Collaborator
|
@adrianriobo I verified with the latest |
Collaborator
Author
|
@lilyLuLiu @psturc thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to refactor on compute-request selector the value for nested virtualization was missing when filtering machines. Then even when the flag was used the type of machines returned are not taking it into consideration. This commit ensures the value is pass again in the filter.
Fixes #563
Fixes #567