fix: AWS PlacementeScoreData API not supported#603
Merged
Conversation
Previously we use the target region for the data as the region to access the API, but some regions do not offer the API, which is different from not having data for the PlacementScore in that region. This commit ensures all API calls to get the data are made to a fixed region where we know the API is available. Fix redhat-developer#602 Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Collaborator
Author
|
@ppitonak if you test this one can you ack here? |
Collaborator
|
Before this change, I was messages like the one below and some regions were skipped, such as With this change, the message for regions with no data changed but I see that I guess that it works as expected. |
ppitonak
approved these changes
Sep 24, 2025
Collaborator
|
Merging is blocked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we use the target region for the data as the region to access the API, but some regions do not offer the API, which is different from not having data for the PlacementScore in that region. This commit ensures all API calls to get the data are made to a fixed region where we know the API is available. Fix #602