fix: aws wrong target region on non-spot instances#615
Merged
Conversation
Collaborator
Author
|
^^ @ppitonak test this one once is avail on ghrc 🙏 and let me knoww |
When backed url is used with a s3 bucket we need to change the region to match the bucket region, then the original target region was never set it back, causing to always use the bucket region to deploy non spot instances. This commit will set it back. Fixes redhat-developer#614. Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
Collaborator
|
I tried to create an on-demand VM in |
Recently the region not offering Placement Score was fixed using a fixed region which offers the API, although the initial problem was solved using one single region for all the requests within the same account generates rate limit errors for API call. This commit introduces a way to randomize the region used to run the request distributing the load of the calls. Fixes redhat-developer#617 Signed-off-by: Adrian Riobo <ariobolo@redhat.com>
ppitonak
approved these changes
Oct 2, 2025
Collaborator
|
LGTM Tested with bot non-spot and spot instances |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When backed url is used with a s3 bucket we need to change the region to match the bucket region, then the original target region was never set it back, causing to always use the bucket region to deploy non spot instances. This commit will set it back.
Fixes #614
Fixes #617