Mask AWS and Azure credentials in debug mode#632
Merged
Conversation
Collaborator
Author
|
Tested with RHEL. |
Collaborator
|
Would you mind to add this to azure tasks as well....if not this is something we will face in the future too ... |
ppitonak
force-pushed
the
mask_aws_creds
branch
from
cc48442 to
0942e63
Compare
Collaborator
Author
|
I pushed the updates also for Azure |
ppitonak
changed the title
Previously when debug mode was active, AWS and Azure credentials were displayed which is very insecure because Tekton logs could be archived for long time. Now only the first and last character of sensitive credentials are displayed. Signed-off-by: Pavol Pitonak <ppitonak@redhat.com>
ppitonak
force-pushed
the
mask_aws_creds
branch
from
0942e63 to
065f972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when debug mode was active, AWS credentials were displayed which is very insecure because Tekton logs could be archived for long time.
Now only the first and last character of sensitive credentials are displayed.