tkn: update task for azure windows desktop

[anjannath]

replace the use of flag --vmsize with --compute-sizes
flag name was updated in bd2d626

[adrianriobo]

Can we switch this to compute-sizes

mapt/tkn/infra-aws-rhel.yaml

Line 251 in 6227813

if [[ "$(params.compute-sizes)" != "" ]]; then

that should be offered there. But I forgot to change here.

[albfan]

In any case, this should use -n (not empty string) instead of -z (empty string) for:

if [[ -z $(params.vmsize) ]]; then cmd+="--vmsize $(params.vmsize) "; fi

[adrianriobo]

@albfan is this breaking your pipelines????

[albfan]

I'm not sure what happens, probably related with fixing empty strings:

#613

In any case, problems with git resolvers on our openshift cluster, make us apply all this task, so we modify manually until we resolve network problems

[adrianriobo]

But are you seeing issues with how those are treated now? he said he tested this with RHEL 🤔

[adrianriobo]

@ppitonak #613 (comment) do you recall what test did you do,...I mean did you test both....compute-size based and non compute-size based?

[ppitonak]

@adrianriobo Frankly, I don't remember but this is for Azure and Windows. I definitely didn't test neither of those.

[adrianriobo]

Yeah I know but I am asking them to back port here your code for checking it... so I would trust the AWS work around it :)

Anyway I will give a try, just to ensure as it is not clear to me, and at this moment mostly:

• CPUs are managed based on params (CPU, Memory,..)
• GPUs are managed based on compute-sizes

So I need to ensure both options work as expected

[ppitonak]

AWS RHEL task gives top priority to compute-sizes if set. If it is not set, then it propagates other params

if [[ "$(params.compute-sizes)" != "" ]]; then
    cmd+="--compute-sizes '$(params.compute-sizes)' "
else
    cmd+="--arch '$(params.arch)' "
    cmd+="--cpus '$(params.cpus)' "
    cmd+="--memory '$(params.memory)' "
    cmd+="--gpus '$(params.gpus)' "
    cmd+="--gpu-manufacturer '$(params.gpu-manufacturer)' "
fi

[adrianriobo]

LGTM