Fix stream name mismatch in code and the text#2555
Open
sJJdGG wants to merge 2 commits intoredis:masterfrom
Open
Fix stream name mismatch in code and the text#2555sJJdGG wants to merge 2 commits intoredis:masterfrom
sJJdGG wants to merge 2 commits intoredis:masterfrom
Conversation
in the code above the suggested diff, the stream name is `race:france` which is coherent with all the other example in the doc. but it's wrongly named `mystream`
✅ Deploy Preview for redis-doc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Collaborator
|
Thank you, Sajjad, for the PR. There are two other occurrences of "mystream" that need to be changed. The first is in the same paragraph you mentioned, line 329. The other is on line 435, where "mystream" should be changed to "race:italy". Can you make these other two changes to this PR? |
dwdougherty
reviewed
Oct 24, 2023
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the code above the suggested diff, the stream name is
race:francewhich is coherent with all the other example in the doc. but it's wrongly namedmystream