Skip to content

Conversation

@b-simjoo
Copy link

@b-simjoo b-simjoo commented Aug 6, 2023

Hi, I added new constant value __INCOMPLETE as default value for optional parameters and then added a new optional parameter named default to get function. When user pass value to default parameter (including None and Ellipsis) then if key not exist it will return default, otherwise it raises NotFoundError

@abrookins
Copy link
Collaborator

Well, this deserved an answer a long time ago! Maintainership of this repo was in flux at the time. I'm belatedly reviewing older PRs, so thank you @b-simjoo for opening the PR. After thinking about this, I'd like to keep get() 100% consistent in raising an error if an object doesn't exist with the target PK. Thanks again!

@abrookins abrookins closed this Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants